Makefile, Unittests and Lint

Commits

• Coverage and unittests - test_controller.py: 28a2e3b72629870e2ff43d59205d992168a5ecb5
• Pylint-testsource.py: c62fd9be3e276497125f44fe92b492c96b5aec86
• Modified Makefile: 836e41f953fe99419f0e913d6ba5cdf19d043a69
• Pylint helpers: 1761c8006e4c2a06b820c9f6f3a40cc82911b1f8
• Pylint controller.py: 8094c21e4a578559e2bdcc1dc4960314393ad63d
• Pylint connection.py: df03803b679192a3535cc798332ce4080e6790b6
• modified .gitignore: e4c0e9d9f990f7469375ae4050e190481858d911
• Added Makefile - pylint: f3f119ed86ed8dc19a3d40978f31e19c3e73f599
• improved syntax - pylint: 828d5b06566e27043b0cfe3a2f679fed9b7e718a
• pylint: deea82673be84ce1db99add6a9fc507ec1201b70
• A bit of pylint - -server.py: c3b73951b0e0795b1ae860442f08877a21af4330
• Added __init__.py. Added __all__ to all files. Added a test.py file: 7dc299753b194a8ea5e78a1c40f0c35354174fe7
• meaningful names to call_sync parameters: ef2b4a490f1dc6a3b46fe1a1d5cb60902521d824
• Modified MockConnection() and its usage: 53c9a0c5cb420749be6c87feeab4e0c145bc62ed
• properties and doc string in place: 07c3348c13a2025a5373e4cd7a5f7c9a2b1cc8ec

Makefile

I made a makefile to automate running py.test, coverage and pylint on the code. This is first time I am writing one :) The one i wrote assumes that py.test (with coverage.py plugin) and pylint is installed on your system.

For running py.test along with coverage:

make coverage
	

For running pylint over the code:

make lint
	

The result is generated as html files in a folder reports in the present working directory.

Linting the code

I ran pylint on my code. Ofc it gave a very huge list of warning/errors! Slowly, they were solved. I tried my best to remove those, but some of those just cannot be removed :) Running pylint using Makefile gives a better estimate of the situation.

Exceptions and Unittests

I also added exceptions and unittests for helper.py and testsource.py. Now the unittests part is almost complete with 100% coverage.

Others..

Some small changes were also made which are reflected from the git commit message history.

TODO:

• Integration tests